From: Tejun Heo <tj@kernel.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Alexei Starovoitov' <alexei.starovoitov@gmail.com>,
Daniel Borkmann <dborkman@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] net: sctp: fix incorrect type in gfp initializer
Date: Wed, 18 Jun 2014 14:30:58 -0400 [thread overview]
Message-ID: <20140618183058.GC11042@htj.dyndns.org> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1725B905@AcuExch.aculab.com>
On Thu, Jun 12, 2014 at 08:46:44AM +0000, David Laight wrote:
> I was slightly worried it might generate the boolean value - something
> that you really don't want it to do.
I don't think gcc is that stupid at this point.
> I only looked at the output for the old version.
> The compiler seemed to have converted:
> if (preload)
> x();
> y;
> if (preload)
> z();
> into:
> if (preload) {
> x(); y; z();
> } else {
> y;
> }
> and then found out that z() was empty, leaving two copies of y().
So, nothing wrong, right?
--
tejun
next prev parent reply other threads:[~2014-06-18 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 14:34 [PATCH net-next 0/5] SCTP update Daniel Borkmann
2014-06-11 14:34 ` [PATCH net-next 1/5] ktime: add ktime_after and ktime_before helper Daniel Borkmann
2014-06-11 14:34 ` [PATCH net-next 2/5] net: sctp: refactor active path selection Daniel Borkmann
2014-06-11 14:34 ` [PATCH net-next 3/5] net: sctp: migrate most recently used transport to ktime Daniel Borkmann
2014-06-11 14:34 ` [PATCH net-next 4/5] net: sctp: improve sctp_select_active_and_retran_path selection Daniel Borkmann
2014-06-11 14:34 ` [PATCH net-next 5/5] net: sctp: fix incorrect type in gfp initializer Daniel Borkmann
2014-06-11 14:55 ` David Laight
2014-06-11 15:09 ` Daniel Borkmann
2014-06-11 17:18 ` Alexei Starovoitov
2014-06-12 8:46 ` David Laight
2014-06-18 18:30 ` Tejun Heo [this message]
2014-06-19 8:13 ` David Laight
2014-06-19 13:46 ` 'Tejun Heo'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618183058.GC11042@htj.dyndns.org \
--to=tj@kernel.org \
--cc=David.Laight@ACULAB.COM \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).