From: David Miller <davem@davemloft.net>
To: chris@logicalelegance.com
Cc: netdev@vger.kernel.org, vermagan@cisco.com, lojakab@cisco.com
Subject: Re: [PATCH V3 net-next] LISP: Locator/Identifier Separation Protocol
Date: Thu, 19 Jun 2014 21:11:11 -0700 (PDT) [thread overview]
Message-ID: <20140619.211111.2189727364823929442.davem@davemloft.net> (raw)
In-Reply-To: <09FAB6E8-D4D5-4685-BC5E-FF6ACE19383B@logicalelegance.com>
From: Christopher White <chris@logicalelegance.com>
Date: Thu, 19 Jun 2014 15:05:53 -0700
> +static inline struct rtable *ip_route_output_mark(struct net *net,
> + __be32 *saddr, __be32 daddr,
> + u8 ipproto, u8 tos, u32 skb_mark)
...
> +static inline __be16 udp_tunnel_get_src_port(__u16 port_min, __u16 port_max,
> + struct sk_buff *skb)
These are not indented properly.
When a declaration, definition, or invocation of a function spans
multiple lines, the arguments on the second and subsequent lines
must begin at the first column after the openning parenthesis on
the first line.
You must use the appropriate number of TAB and SPACE characters
necessary to achieve this. If you are indenting purely with
TAB characters, you are doing it wrong.
next prev parent reply other threads:[~2014-06-20 4:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 22:05 [PATCH V3 net-next] LISP: Locator/Identifier Separation Protocol Christopher White
2014-06-20 4:11 ` David Miller [this message]
2014-06-20 4:18 ` Chris White
-- strict thread matches above, loose matches on Subject: below --
2014-06-18 23:07 Christopher White
2014-06-19 0:08 ` Tom Herbert
2014-06-19 16:31 ` Christopher White
2014-06-19 17:29 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619.211111.2189727364823929442.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris@logicalelegance.com \
--cc=lojakab@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=vermagan@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox