From: David Miller <davem@davemloft.net>
To: anish@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com, hariprasad@chelsio.com
Subject: Re: [PATCH net-next 2/5] cxgb4 : Add DCBx support codebase and dcbnl_ops
Date: Thu, 19 Jun 2014 21:15:46 -0700 (PDT) [thread overview]
Message-ID: <20140619.211546.719163351289410442.davem@davemloft.net> (raw)
In-Reply-To: <1403216531-7874-3-git-send-email-anish@chelsio.com>
From: Anish Bhatt <anish@chelsio.com>
Date: Thu, 19 Jun 2014 15:22:08 -0700
> +#ifdef CONFIG_CHELSIO_T4_DCB
> + struct port_dcb_info dcb; /* Data Center Bridging support */
> +#endif
Don't reference data structure which do not exist until patches
later in your series. Add those definitions first.
Your submission is impossible to review, and in fact presents itself
illogically, when you introduce infrastructure after it's uses.
next prev parent reply other threads:[~2014-06-20 4:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 22:22 [PATCH net-next 0/5] Add DCBx support to Chelsio cxgb4 driver Anish Bhatt
2014-06-19 22:22 ` [PATCH net-next 1/5] cxgb4 : Update fw interface file for DCBx support. Adds all the required fields to fw interface to communicate DCBx info Anish Bhatt
2014-06-19 22:22 ` [PATCH net-next 2/5] cxgb4 : Add DCBx support codebase and dcbnl_ops Anish Bhatt
2014-06-20 4:15 ` David Miller [this message]
2014-06-19 22:22 ` [PATCH net-next 3/5] cxgb4 : Integrate DCBx support into cxgb4 module. Register dbcnl_ops to give access to DCBx functions Anish Bhatt
2014-06-19 22:22 ` [PATCH net-next 4/5] cxgb4 : Makefile & Kconfig changes for DCBx support Anish Bhatt
2014-06-20 16:51 ` Sergei Shtylyov
2014-06-19 22:22 ` [PATCH net-next 5/5] cxgb4 : Update copyright year on all cxgb4 files Anish Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619.211546.719163351289410442.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).