* re: net: return actual error on register_queue_kobjects
@ 2014-06-19 21:28 Dan Carpenter
2014-06-19 21:39 ` Alexei Starovoitov
2014-06-20 1:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-06-19 21:28 UTC (permalink / raw)
To: jeff.liu; +Cc: netdev
Hello Jie Liu,
The patch d36a4f4b4723: "net: return actual error on
register_queue_kobjects" from Jun 17, 2014, leads to the following
static checker warning:
net/core/net-sysfs.c:1203 register_queue_kobjects()
warn: 'net->queues_kset' isn't an ERR_PTR
net/core/net-sysfs.c
1200 #ifdef CONFIG_SYSFS
1201 net->queues_kset = kset_create_and_add("queues",
^^^^^^^^^^^^^^^^^^^
This function returns a NULL on error doesn't it? In linux-next it
does. The patch description is not clear.
1202 NULL, &net->dev.kobj);
1203 if (IS_ERR(net->queues_kset))
1204 return PTR_ERR(net->queues_kset);
1205 real_rx = net->real_num_rx_queues;
1206 #endif
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net: return actual error on register_queue_kobjects
2014-06-19 21:28 net: return actual error on register_queue_kobjects Dan Carpenter
@ 2014-06-19 21:39 ` Alexei Starovoitov
2014-06-20 1:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2014-06-19 21:39 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman, David S. Miller
Cc: jeff.liu, netdev@vger.kernel.org
On Thu, Jun 19, 2014 at 2:28 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Hello Jie Liu,
>
> The patch d36a4f4b4723: "net: return actual error on
> register_queue_kobjects" from Jun 17, 2014, leads to the following
> static checker warning:
>
> net/core/net-sysfs.c:1203 register_queue_kobjects()
> warn: 'net->queues_kset' isn't an ERR_PTR
>
> net/core/net-sysfs.c
> 1200 #ifdef CONFIG_SYSFS
> 1201 net->queues_kset = kset_create_and_add("queues",
> ^^^^^^^^^^^^^^^^^^^
> This function returns a NULL on error doesn't it? In linux-next it
> does. The patch description is not clear.
that patch is broken and should be reverted as Jeff said:
--
From: Jeff Liu <jeff.liu@oracle.com>
> You will have to watch very carefully to ensure that those patches do
> not now get accepted, as they will break the existing code.
Ok, and I'll inform every other maintainers do not apply their patch
individually.
Cheers,
-Jeff
--
From: Jeff Liu <jeff.liu@oracle.com>
Yes, could you please remove this patch? sorry for the convenient!
--
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: net: return actual error on register_queue_kobjects
2014-06-19 21:28 net: return actual error on register_queue_kobjects Dan Carpenter
2014-06-19 21:39 ` Alexei Starovoitov
@ 2014-06-20 1:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-06-20 1:12 UTC (permalink / raw)
To: dan.carpenter; +Cc: jeff.liu, netdev
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 20 Jun 2014 00:28:40 +0300
> The patch d36a4f4b4723: "net: return actual error on
> register_queue_kobjects" from Jun 17, 2014, leads to the following
> static checker warning:
I've reverted it from my tree, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-20 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19 21:28 net: return actual error on register_queue_kobjects Dan Carpenter
2014-06-19 21:39 ` Alexei Starovoitov
2014-06-20 1:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).