From: David Miller <davem@davemloft.net>
To: cascardo@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, hariprasad@chelsio.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxgb4: use dev_port to identify ports
Date: Sun, 22 Jun 2014 17:23:07 -0700 (PDT) [thread overview]
Message-ID: <20140622.172307.2305001882391366010.davem@davemloft.net> (raw)
In-Reply-To: <1403354888-15600-1-git-send-email-cascardo@linux.vnet.ibm.com>
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Sat, 21 Jun 2014 09:48:08 -0300
> Commit 3f85944fe207d0225ef21a2c0951d4946fc9a95d ("net: Add sysfs file
> for port number") introduce dev_port to network devices. cxgb4 adapters
> have multiple ports on the same PCI function, and used dev_id to
> identify those ports. That use was removed by commit
> 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set
> net_device::dev_id to VI index"), since dev_id should be used only when
> devices share the same MAC address.
>
> Using dev_port for cxgb4 allows different ports on the same PCI function
> to be identified.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
You've made exactly zero effort to explain why the IPV6 issue carefully
explained in commit 8c367fcbe6549195d2eb11e62bea233f811aad41 no longer
applies.
As far as I can tell, it absolutely does, and therefore this change
here should not be made.
I'm not applying this patch, sorry.
next prev parent reply other threads:[~2014-06-23 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 12:48 [PATCH] cxgb4: use dev_port to identify ports Thadeu Lima de Souza Cascardo
2014-06-23 0:23 ` David Miller [this message]
2014-06-23 12:16 ` Thadeu Lima de Souza Cascardo
2014-06-25 23:02 ` David Miller
2014-06-25 23:08 ` Luis R. Rodriguez
2014-06-26 12:37 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140622.172307.2305001882391366010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cascardo@linux.vnet.ibm.com \
--cc=hariprasad@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).