netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: greg@kroah.com
Cc: olaf@aepfle.de, netdev@vger.kernel.org, jasowang@redhat.com,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, haiyangz@microsoft.com
Subject: Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event
Date: Mon, 23 Jun 2014 13:11:44 -0700 (PDT)	[thread overview]
Message-ID: <20140623.131144.199410086942856418.davem@davemloft.net> (raw)
In-Reply-To: <20140623162911.GA20715@kroah.com>

From: Greg KH <greg@kroah.com>
Date: Mon, 23 Jun 2014 12:29:11 -0400

> Given that this change will fail on all future distro releases, and
> almost all of the community distros today, I don't see how this is
> acceptable at all.  Nor would it be any better if you switch to a
> systemd command line script as well.  You should just work like any
> other network device works in this situation when it comes to
> enabling/disabling the device.  Worse case, just tear down the whole
> network device at suspend time, and recreate it at resume.

Agreed, and I've strongly asked them to remove this code immediately.

  parent reply	other threads:[~2014-06-23 20:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  1:34 [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event Haiyang Zhang
2014-06-20  4:21 ` David Miller
2014-06-20  4:57 ` Olaf Hering
2014-06-20  5:12   ` Greg KH
2014-06-20 16:09     ` Haiyang Zhang
2014-06-23  8:02       ` Olaf Hering
2014-06-23 12:47         ` Haiyang Zhang
2014-06-23 13:17           ` Olaf Hering
2014-06-23 16:09             ` Haiyang Zhang
2014-06-23 16:27               ` Olaf Hering
2014-06-23 18:21                 ` Haiyang Zhang
2014-06-26  8:45                   ` Olaf Hering
2014-06-26 14:55                     ` Haiyang Zhang
2014-06-23 16:29               ` Greg KH
2014-06-23 18:23                 ` Haiyang Zhang
2014-06-23 20:11                 ` David Miller [this message]
2014-06-23 20:10               ` David Miller
2014-06-23 20:17                 ` Haiyang Zhang
2015-10-27 22:36                 ` Richard Weinberger
2015-10-28 17:59                   ` Haiyang Zhang
2015-10-29 19:09                   ` Haiyang Zhang
2015-10-30 10:56                     ` Vitaly Kuznetsov
2015-10-30 22:03                       ` Haiyang Zhang
2015-10-30 22:10                         ` Richard Weinberger
2014-06-23 20:06             ` David Miller
2014-06-20  8:41 ` Dan Carpenter
2014-06-20 15:48   ` Haiyang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140623.131144.199410086942856418.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=greg@kroah.com \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).