From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] be2net: fix qnq mode detection on VFs
Date: Mon, 23 Jun 2014 14:47:07 -0700 (PDT) [thread overview]
Message-ID: <20140623.144707.29017823029772168.davem@davemloft.net> (raw)
In-Reply-To: <1403521889-8048-1-git-send-email-sathya.perla@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Mon, 23 Jun 2014 16:41:29 +0530
> From: Suresh Reddy <suresh.reddy@emulex.com>
>
> The driver (on PF or VF) needs to detect if the function is in qnq mode for
> a HW hack in be_rx_compl_get() to work.
>
> The driver queries this information using the GET_PROFILE_CONFIG cmd
> (since the commit below can caused this regression.) But this cmd is not
> available on VFs and so the VFs fail to detect qnq mode. This causes
> vlan traffic to not work.
>
> The fix is to use the the adapter->function_mode value queried via
> QUERY_FIRMWARE_CONFIG cmd on both PFs and VFs to detect the qnq mode.
>
> Also QNQ_MODE was incorrectly named FLEX10_MODE; correcting that too as the
> fix reads much better with the name change.
>
> Fixes: f93f160b5 ("refactor multi-channel config code for Skyhawk-R chip")
>
> Signed-off-by: Suresh Reddy <Suresh.Reddy@emulex.com>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied, thanks.
prev parent reply other threads:[~2014-06-23 21:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 11:11 [PATCH net] be2net: fix qnq mode detection on VFs Sathya Perla
2014-06-23 21:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623.144707.29017823029772168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).