From: Simon Horman <horms@verge.net.au>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Wensong Zhang <wensong@linux-vs.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net/netfilter/ipvs/ip_vs_sync.c: remove null test before kfree
Date: Mon, 23 Jun 2014 11:20:56 +0900 [thread overview]
Message-ID: <20140623022056.GA12564@verge.net.au> (raw)
In-Reply-To: <1403296542-5992-1-git-send-email-fabf@skynet.be>
On Fri, Jun 20, 2014 at 10:35:42PM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Wensong Zhang <wensong@linux-vs.org>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Thanks, applied.
> ---
> net/netfilter/ipvs/ip_vs_sync.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index db80126..eadffb2 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -886,8 +886,7 @@ static void ip_vs_proc_conn(struct net *net, struct ip_vs_conn_param *param,
> cp = ip_vs_conn_new(param, daddr, dport, flags, dest, fwmark);
> rcu_read_unlock();
> if (!cp) {
> - if (param->pe_data)
> - kfree(param->pe_data);
> + kfree(param->pe_data);
> IP_VS_DBG(2, "BACKUP, add new conn. failed\n");
> return;
> }
> --
> 1.8.4.5
>
prev parent reply other threads:[~2014-06-23 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 20:35 [PATCH 1/1] net/netfilter/ipvs/ip_vs_sync.c: remove null test before kfree Fabian Frederick
2014-06-23 2:20 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623022056.GA12564@verge.net.au \
--to=horms@verge.net.au \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).