From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: davem@davemloft.net
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, boris.ostrovsky@oracle.com,
ian.campbell@citrix.com, xen-devel@lists.xen.org,
wei.liu2@citrix.com
Subject: Is: automated testing before David M picks them up? Was: Re: [Xen-devel] [PATCH net v2] xen-netback: bookkeep number of active queues in our own module
Date: Mon, 23 Jun 2014 11:31:51 -0400 [thread overview]
Message-ID: <20140623153151.GA3261@laptop.dumpdata.com> (raw)
In-Reply-To: <20140623084032.GU20819@zion.uk.xensource.com>
> > Your previous patch didn't do this, and I really am suspect as to
> > whether you functionally tested and verified this aspect of your
> > change at a ll.
> >
>
> I've done some testing.
>
Hey David M,
First of sorry for hijacking this thread - but it seemed like the
perfect thread.
David Vrabel raised an interesting point is that we do have an automated
build/test system that finds bugs - and in fact the 3.16-rc1 netfront
and netback bugs were discovered by that (Boris watches them like
hawks and pounces on them immediately).
That being said - all patches that go through the Xen tree (xen/tip.git)
go through that - and also the ones that maintainers do a git pull
on (say for drivers/block/*). But for xen-net* we don't do that since
well.. it hasn't been a problem in the past and we never formulated
a policy for that. (It was easy with Jens' because he likes the
GIT PULL mechanism and we just created a branch in the tree - and I also
managed to cause some embbarasing bugs so to save my face I am now
testing it religiously).
Having said that - how do you handle such situation with sub-maintainers
wanting to do some testing before they are cleared to go your way?
next prev parent reply other threads:[~2014-06-27 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 13:31 [PATCH net v2] xen-netback: bookkeep number of active queues in our own module Wei Liu
2014-06-23 0:21 ` David Miller
2014-06-23 8:40 ` Wei Liu
2014-06-23 9:11 ` David Miller
2014-06-23 15:31 ` Konrad Rzeszutek Wilk [this message]
2014-06-27 19:34 ` Is: automated testing before David M picks them up? Was: Re: [Xen-devel] " David Miller
2014-06-30 8:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623153151.GA3261@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).