From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
tiwai@suse.de, chunkeey@googlemail.com, leedom@chelsio.com,
cocci@systeme.lip6.fr, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] p54: use request_firmware_direct() for optional EEPROM override
Date: Wed, 25 Jun 2014 10:06:05 +0200 [thread overview]
Message-ID: <20140625080605.GN27687@wotan.suse.de> (raw)
In-Reply-To: <53AA799F.7030807@broadcom.com>
On Wed, Jun 25, 2014 at 09:26:23AM +0200, Arend van Spriel wrote:
> On 25-06-14 00:39, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>>
>> The p54 driver uses request_firmware() twice, once for actual
>> firmware and then another time for an optional user overide on
>> EEPROM, 3826.eeprom. The custom EEPROM is optional but if not
>> present we'll introduce an extra lag of 60 seconds with udev
>> present. Annotate we don't want udev nonsense here to avoid
>> the lag in case its not present.
>
> I guess the fact that EEPROM is optional does not matter much. If doing a
> second request you could always use request_firmware_direct(), right?
The better way to rephrase this from a technical perspective is:
I don't care about udev firmware upload as it'll be removed, and its only
adding 60 second delays. I *know* this driver doesn't require custom paths and
wierd user upload tools so lets evolve a few light years ahead and embrace
non-udev Direct upload for at least optional juju config data.
Luis
next prev parent reply other threads:[~2014-06-25 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 22:39 [PATCH 0/3] drivers: expand usage of request_firmware_direct() Luis R. Rodriguez
2014-06-24 22:39 ` [PATCH 1/3] mmc: vub300: use request_firmware_direct() for pseudo code Luis R. Rodriguez
2014-06-24 22:39 ` [PATCH 2/3] cxgb4: make configuration load use request_firmware_direct() Luis R. Rodriguez
2014-06-24 22:54 ` Casey Leedom
2014-06-25 1:50 ` Luis R. Rodriguez
2014-06-25 17:12 ` Casey Leedom
2014-06-25 17:31 ` Luis R. Rodriguez
2014-06-25 18:58 ` Casey Leedom
2014-06-25 20:05 ` Luis R. Rodriguez
2014-06-24 22:39 ` [PATCH 3/3] p54: use request_firmware_direct() for optional EEPROM override Luis R. Rodriguez
2014-06-25 1:10 ` [RESEND][PATCH " Christian Lamparter
2014-06-25 7:26 ` [PATCH " Arend van Spriel
2014-06-25 8:06 ` Luis R. Rodriguez [this message]
2014-06-26 16:18 ` [PATCH 0/3] drivers: expand usage of request_firmware_direct() Takashi Iwai
2014-06-26 19:21 ` Greg KH
2014-07-08 22:25 ` Greg KH
2014-07-08 23:52 ` Luis R. Rodriguez
2014-07-09 0:24 ` Greg KH
2014-07-09 0:46 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625080605.GN27687@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=arend@broadcom.com \
--cc=chunkeey@googlemail.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).