From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tom Herbert <therbert@google.com>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment
Date: Wed, 25 Jun 2014 10:10:52 -0400 [thread overview]
Message-ID: <20140625141052.GA1096@redhat.com> (raw)
In-Reply-To: <CA+55aFxyZP_jXT-bLyFjJMp4WfVZp5vFtpu+-6_qCi46xkceQg@mail.gmail.com>
On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote:
> On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert <therbert@google.com> wrote:
> >
> > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is
> > not set correctly when doing non-scatter gather. We are using
> > offset as opposed to doffset.
> >
> > Reported-by: Dave Jones <davej@redhat.com>
>
> DaveJ, I think you triggered this in five minutes on your box, and I
> don't recall seeing anybody else reporting the oops (and google
> doesn't find anything in the last month). So it's presumably somewhat
> hw-specific. Does this fix the problem?
It's survived routing ~1GB of packets overnight, so I'd call this good.
thanks Tom.
Dave
next prev parent reply other threads:[~2014-06-25 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 4:03 [PATCH] tcp: fix setting csum_start in tcp_gso_segment Tom Herbert
2014-06-25 4:17 ` Linus Torvalds
2014-06-25 14:10 ` Dave Jones [this message]
2014-06-25 18:52 ` David Miller
2014-06-25 7:19 ` Eric Dumazet
2014-06-25 19:51 ` [PATCH] net: fix setting csum_start in skb_segment() Eric Dumazet
2014-06-26 2:15 ` Tom Herbert
2014-06-26 3:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625141052.GA1096@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).