From: David Miller <davem@davemloft.net>
To: jhs@mojatatu.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
vyasevic@redhat.com, sfeldma@cumulusnetworks.com,
john.r.fastabend@intel.com, roopa@cumulusnetworks.com,
eric.dumazet@gmail.com
Subject: Re: [net-next PATCH v3 2/2] bridge: netlink dump interface at par with brctl
Date: Thu, 26 Jun 2014 17:45:30 -0700 (PDT) [thread overview]
Message-ID: <20140626.174530.4353389845713242.davem@davemloft.net> (raw)
In-Reply-To: <1403691683-14290-3-git-send-email-jhs@emojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Wed, 25 Jun 2014 06:21:23 -0400
> + /*
> + * !f->dst is a speacial case for bridge
> + * It means the MAC belongs to the bridge
> + * Therefore need a little more filtering
> + * we only want to dump the !f->dst case
> + */
Please format comments:
/* Like
* this.
*/
in the networking.
> + for_each_netdev(net, dev) {
> +
> + if (brport_idx && (dev->ifindex != brport_idx))
Please remove that empty line.
> + if (cops && cops->ndo_fdb_dump) {
> + idx = cops->ndo_fdb_dump(skb, cb, br_dev, dev, idx);
> + }
Single statement basic blocks do not need curly braces.
> + if (dev->netdev_ops->ndo_fdb_dump) {
> + idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, bdev, dev,
> + idx);
> }
Likewise.
next prev parent reply other threads:[~2014-06-27 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 10:21 [net-next PATCH v3 0/2] bridge: more efficient fdb dumping Jamal Hadi Salim
2014-06-25 10:21 ` [net-next PATCH v3 1/2] bridge: fdb dumping takes a filter device Jamal Hadi Salim
2014-06-25 10:21 ` [net-next PATCH v3 2/2] bridge: netlink dump interface at par with brctl Jamal Hadi Salim
2014-06-27 0:45 ` David Miller [this message]
2014-06-25 10:25 ` [net-next PATCH v3 0/2] bridge: more efficient fdb dumping Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626.174530.4353389845713242.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).