From: Richard Cochran <richardcochran@gmail.com>
To: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] ptp: Allow reassigning calibration pin function
Date: Thu, 26 Jun 2014 07:21:45 +0200 [thread overview]
Message-ID: <20140626052144.GB4537@netboy> (raw)
In-Reply-To: <1403699851-11178-2-git-send-email-stefan.sorensen@spectralink.com>
On Wed, Jun 25, 2014 at 02:37:29PM +0200, Stefan Sørensen wrote:
> The ptp pin function programming does not allow calibration pin to change
> function. This is problematic on hardware that uses the default calibration
> pin for other purposes.
>
> Removing this limitation does not impact calibration if userspace does not
> reprogram the calibration pin.
Reassigning the calibration function never makes sense, because it is
only used in the driver probe method.
Clobbering the calibration pin with another function only makes sense
if the hardware design has exactly one PHY.
Can you please add a check in the dp83640 verify method to enforce
these two constraints?
Thanks,
Richard
next prev parent reply other threads:[~2014-06-26 5:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 12:37 [PATCH net-next 0/3] dp83640: Increase support perout pins Stefan Sørensen
2014-06-25 12:37 ` [PATCH net-next 1/3] ptp: Allow reassigning calibration pin function Stefan Sørensen
2014-06-26 5:21 ` Richard Cochran [this message]
2014-06-26 6:14 ` Christian Riesch
2014-06-26 6:16 ` Christian Riesch
2014-06-26 14:57 ` Richard Cochran
2014-06-25 12:37 ` [PATCH net-next 2/3] dp83640: Program pulsewidth2 values of perout triggers 0 and 1 Stefan Sørensen
2014-06-25 17:50 ` Sergei Shtylyov
2014-06-25 12:37 ` [PATCH net-next 3/3] dp83640: Increase supported perout pins to 7 Stefan Sørensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626052144.GB4537@netboy \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).