From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Hariprasad Shenai <hariprasad@chelsio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxgb4: use dev_port to identify ports
Date: Thu, 26 Jun 2014 09:37:09 -0300 [thread overview]
Message-ID: <20140626123709.GA9256@oc0268524204.ibm.com> (raw)
In-Reply-To: <CAB=NE6VWa4O0nycSo55ip075MEXXB_0k4wVnorSziRQmKRUmLg@mail.gmail.com>
On Wed, Jun 25, 2014 at 04:08:21PM -0700, Luis R. Rodriguez wrote:
> On Sat, Jun 21, 2014 at 5:48 AM, Thadeu Lima de Souza Cascardo
> <cascardo@linux.vnet.ibm.com> wrote:
> > That use was removed by commit
> > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set
> > net_device::dev_id to VI index"), since dev_id should be used only when
> > devices share the same MAC address.
> >
> > Using dev_port for cxgb4 allows different ports on the same PCI function
> > to be identified.
>
> Can you describe what issues were introduced because of this then?
>
> Luis
>
udevd builtin net-id cannot rename the interfaces, since it relies on
the dev_id for interfaces on the same PCI function. I am going to send a
patch to use dev_port instead, and fallback to dev_id, and copy netdev.
Regards.
Cascardo.
prev parent reply other threads:[~2014-06-26 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-21 12:48 [PATCH] cxgb4: use dev_port to identify ports Thadeu Lima de Souza Cascardo
2014-06-23 0:23 ` David Miller
2014-06-23 12:16 ` Thadeu Lima de Souza Cascardo
2014-06-25 23:02 ` David Miller
2014-06-25 23:08 ` Luis R. Rodriguez
2014-06-26 12:37 ` Thadeu Lima de Souza Cascardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626123709.GA9256@oc0268524204.ibm.com \
--to=cascardo@linux.vnet.ibm.com \
--cc=hariprasad@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).