From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
To: Kay Sievers <kay@vrfy.org>
Cc: netdev@vger.kernel.org
Subject: Re: [systemd-devel] [PATCH] Use dev_port for the ID of a network device.
Date: Tue, 1 Jul 2014 09:32:08 -0300 [thread overview]
Message-ID: <20140701123208.GC1204@oc0268524204.ibm.com> (raw)
In-Reply-To: <CAPXgP13o=qZc0q+Af0sd6bLKUawKYw0L_SLqh3VgLZBJ1CfYSA@mail.gmail.com>
On Tue, Jul 01, 2014 at 02:33:19AM +0200, Kay Sievers wrote:
> On Mon, Jun 30, 2014 at 10:36 PM, Thadeu Lima de Souza Cascardo
> <cascardo@linux.vnet.ibm.com> wrote:
> > For network devices on the same PCI function, dev_id should not be used,
> > since its purpose is for IPv6 support on interfaces with the same MAC
> > address.
> >
> > The new dev_port sysfs attribute should be used when it is found. When
> > it is not, using dev_id might work.
>
> I don't see a problem switching this over, but why would we keep using
> dev_id if it is not the right thing to use?
>
> Kay
>
Because dev_port has only been introduced into Linux 3.15, and some
drivers used dev_id before Linux 3.10. It's not an ideal situation, so I
think it's important to keep some compatibility for the time being. Or
we could simply drop dev_id, and force everyone to do the right thing
and backport dev_port support and fix their drivers.
Cascardo.
next prev parent reply other threads:[~2014-07-01 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 20:36 [PATCH] Use dev_port for the ID of a network device Thadeu Lima de Souza Cascardo
2014-07-01 0:33 ` Kay Sievers
2014-07-01 12:32 ` Thadeu Lima de Souza Cascardo [this message]
2014-07-01 12:45 ` [systemd-devel] " Tom Gundersen
2014-07-01 12:59 ` Kay Sievers
2014-07-01 13:18 ` Amir Vadai
2014-07-01 6:45 ` Bjørn Mork
2014-07-01 7:40 ` Bjørn Mork
2014-07-01 12:25 ` Thadeu Lima de Souza Cascardo
2014-07-01 12:26 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701123208.GC1204@oc0268524204.ibm.com \
--to=cascardo@linux.vnet.ibm.com \
--cc=kay@vrfy.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).