From: Mark Rutland <mark.rutland@arm.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"dave.taht@gmail.com" <dave.taht@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver for QCA7000
Date: Tue, 1 Jul 2014 18:46:16 +0100 [thread overview]
Message-ID: <20140701174616.GA10927@leverpostej> (raw)
In-Reply-To: <1404232609-4314-3-git-send-email-stefan.wahren@i2se.com>
Hi,
On Tue, Jul 01, 2014 at 05:36:49PM +0100, Stefan Wahren wrote:
> This patch adds the Ethernet over SPI driver for the
> Qualcomm QCA7000 HomePlug GreenPHY.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/net/ethernet/Kconfig | 1 +
> drivers/net/ethernet/Makefile | 1 +
> drivers/net/ethernet/qualcomm/Kconfig | 30 +
> drivers/net/ethernet/qualcomm/Makefile | 6 +
> drivers/net/ethernet/qualcomm/qca_7k.c | 149 ++++
> drivers/net/ethernet/qualcomm/qca_7k.h | 72 ++
> drivers/net/ethernet/qualcomm/qca_debug.c | 311 +++++++++
> drivers/net/ethernet/qualcomm/qca_debug.h | 34 +
> drivers/net/ethernet/qualcomm/qca_framing.c | 155 +++++
> drivers/net/ethernet/qualcomm/qca_framing.h | 134 ++++
> drivers/net/ethernet/qualcomm/qca_spi.c | 1001 +++++++++++++++++++++++++++
> drivers/net/ethernet/qualcomm/qca_spi.h | 114 +++
> 12 files changed, 2008 insertions(+)
> create mode 100644 drivers/net/ethernet/qualcomm/Kconfig
> create mode 100644 drivers/net/ethernet/qualcomm/Makefile
> create mode 100644 drivers/net/ethernet/qualcomm/qca_7k.c
> create mode 100644 drivers/net/ethernet/qualcomm/qca_7k.h
> create mode 100644 drivers/net/ethernet/qualcomm/qca_debug.c
> create mode 100644 drivers/net/ethernet/qualcomm/qca_debug.h
> create mode 100644 drivers/net/ethernet/qualcomm/qca_framing.c
> create mode 100644 drivers/net/ethernet/qualcomm/qca_framing.h
> create mode 100644 drivers/net/ethernet/qualcomm/qca_spi.c
> create mode 100644 drivers/net/ethernet/qualcomm/qca_spi.h
[...]
> + if (of_find_property(spi_device->dev.of_node,
> + "qca,legacy-mode", NULL)) {
> + legacy_mode = 1;
> + }
Please use of_property_read bool for boolean properties. Here you can
have:
legacy_mode = of_property_read_bool(spi_device->dev.of_node,
"qca,legacy-mode")
[...]
> +
> + if (qcaspi_clkspeed == 0) {
> + if (of_find_property(spi_device->dev.of_node,
> + "spi-max-frequency", NULL)) {
> + qcaspi_clkspeed = spi_device->max_speed_hz;
> + } else {
> + qcaspi_clkspeed = QCASPI_CLK_SPEED;
> + }
> + }
As far as I can see, of_register_spi_devices leaves
spi_device->max_speed_hz zeroed if there's no spi-max-speed property, so
here you could have:
qcaspi_clkspeed = spi_device->max_speed_hz ?: QCASPI_CLK_SPEED;
Which avoids redundant DT parsing.
[...]
> + memcpy(qca->net_dev->dev_addr, mac, ETH_ALEN);
I believe that it is preferred to write:
ether_addr_copy(qca->net_dev->dev_addr, mac);
I believe checkpatch has a warning for this.
Thanks,
Mark.
next prev parent reply other threads:[~2014-07-01 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:36 [PATCH RFC V2 0/2] add Qualcomm QCA7000 ethernet driver Stefan Wahren
2014-07-01 16:36 ` [PATCH RFC V2 1/2] Documentation: add Device tree bindings for QCA7000 Stefan Wahren
2014-07-01 17:33 ` Sergei Shtylyov
2014-07-02 7:01 ` Stefan Wahren
2014-07-02 11:51 ` Sergei Shtylyov
2014-07-02 15:37 ` Stefan Wahren
2014-07-01 16:36 ` [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver " Stefan Wahren
2014-07-01 17:37 ` Joe Perches
2014-07-01 17:46 ` Mark Rutland [this message]
2014-07-01 17:57 ` Joe Perches
2014-07-01 18:16 ` Mark Rutland
2014-07-03 9:49 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701174616.GA10927@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).