From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: madalin.bucur@freescale.com, roy.qing.li@gmail.com,
edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] vlan: free percpu stats in device destructor
Date: Wed, 02 Jul 2014 17:02:35 -0700 (PDT) [thread overview]
Message-ID: <20140702.170235.955058899063669298.davem@davemloft.net> (raw)
In-Reply-To: <1404293115.23797.15.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 02 Jul 2014 02:25:15 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Madalin-Cristian reported crashs happening after a recent commit
> (5a4ae5f6e7d4 "vlan: unnecessary to check if vlan_pcpu_stats is NULL")
...
> Fix this problem by freeing percpu stats from dev->destructor() instead
> of ndo_uninit()
>
> Reported-by: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Tested-by: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
> Fixes: 5a4ae5f6e7d4 ("vlan: unnecessary to check if vlan_pcpu_stats is NULL")
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2014-07-03 0:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:55 segfault after VLAN change Madalin-Cristian Bucur
2014-07-02 7:11 ` Bjørn Mork
2014-07-02 8:23 ` Eric Dumazet
2014-07-02 8:33 ` Eric Dumazet
2014-07-02 8:55 ` Madalin-Cristian Bucur
2014-07-02 10:22 ` Bjørn Mork
2014-07-02 9:25 ` [PATCH net] vlan: free percpu stats in device destructor Eric Dumazet
2014-07-03 0:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702.170235.955058899063669298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).