Re: [patch net-next] bonding: allow to add vlans on top of empty bond

[Michal Kubecek <mkubecek@suse.cz>]

On Wed, Jul 02, 2014 at 10:46:52AM +0200, Jiri Pirko wrote:
> Fri, Jun 27, 2014 at 06:08:50PM CEST, jay.vosburgh@canonical.com wrote:
> >
> >        if (!bond_has_slaves(bond)) {
> >                bond_set_carrier(bond);
> >                eth_hw_addr_random(bond_dev);
> >
> >                if (vlan_uses_dev(bond_dev)) {
> >                        pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n",
> >                                bond_dev->name, bond_dev->name);
> >                        pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n",
> >                                bond_dev->name);
> >                }
> >        }
> >
> >	This warning may not be useful any longer, since the MAC should
> >update correctly without user action when re-adding the first slave.
> 
> I just checked. The vlan dev holds its addr. So when new slave is added,
> bond addr is changed to it, but vlan addr remains the same. So the
> second warning still stands.

Is it a problem? Since we have proper uc_list propagation, vlan should
work even if its address doesn't match the bond.

                                                        Michal Kubecek