* Re: [PATCH net-next repost v2 1/3] net: Simplify ptp class checks
[not found] ` <1404312104-19154-2-git-send-email-stefan.sorensen@spectralink.com>
@ 2014-07-02 17:48 ` Richard Cochran
0 siblings, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2014-07-02 17:48 UTC (permalink / raw)
To: Stefan Sørensen; +Cc: davem, kaber, netdev
On Wed, Jul 02, 2014 at 04:41:42PM +0200, Stefan Sørensen wrote:
> Replace two switch statements enumerating all valid ptp classes with an if
> statement matching for not PTP_CLASS_NONE.
Originally, I had the explicit list to guard against the possibility
of a filter returning early without some valid PTP_CLASS. I agree with
this change, but we will have to remember to make sure the filter
always returns NONE when the packet isn't recognized.
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <1404312104-19154-3-git-send-email-stefan.sorensen@spectralink.com>]
* Re: [PATCH net-next repost v2 2/3] ptp: Classify ptp over ip over vlan packets
[not found] ` <1404312104-19154-3-git-send-email-stefan.sorensen@spectralink.com>
@ 2014-07-05 18:58 ` Richard Cochran
0 siblings, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2014-07-05 18:58 UTC (permalink / raw)
To: Stefan Sørensen; +Cc: davem, kaber, netdev
On Wed, Jul 02, 2014 at 04:41:43PM +0200, Stefan Sørensen wrote:
> This extends the ptp bpf to also match ptp over ip over vlan packets. The ptp
> classes are changed to orthogonal bitfields representing version, transport
> and vlan values to simplify matching.
>
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
I like the simplied matching routines, and I also checked the BPF_ASM
program. Thanks for this patch series.
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <1404312104-19154-4-git-send-email-stefan.sorensen@spectralink.com>]
end of thread, other threads:[~2014-07-05 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1404312104-19154-1-git-send-email-stefan.sorensen@spectralink.com>
[not found] ` <1404312104-19154-2-git-send-email-stefan.sorensen@spectralink.com>
2014-07-02 17:48 ` [PATCH net-next repost v2 1/3] net: Simplify ptp class checks Richard Cochran
[not found] ` <1404312104-19154-3-git-send-email-stefan.sorensen@spectralink.com>
2014-07-05 18:58 ` [PATCH net-next repost v2 2/3] ptp: Classify ptp over ip over vlan packets Richard Cochran
[not found] ` <1404312104-19154-4-git-send-email-stefan.sorensen@spectralink.com>
2014-07-05 18:59 ` [PATCH net-next repost v2 3/3] vlan: Pass SIOC[SG]HWTSTAMP ioctls to real device Richard Cochran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).