From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: Performance fix for process_backlog
Date: Mon, 07 Jul 2014 19:25:19 -0700 (PDT) [thread overview]
Message-ID: <20140707.192519.1302110449886053251.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1406300949290.5624@tomh.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Mon, 30 Jun 2014 09:50:40 -0700 (PDT)
> In process_backlog the input_pkt_queue is only checked once for new
> packets and quota is artificially reduced to reflect precisely the
> number of packets on the input_pkt_queue so that the loop exits
> appropriately.
>
> This patches changes the behavior to be more straightforward and
> less convoluted. Packets are processed until either the quota
> is met or there are no more packets to process.
>
> This patch seems to provide a small, but noticeable performance
> improvement. The performance improvement is a result of staying
> in the process_backlog loop longer which can reduce number of IPI's.
>
> Performance data using super_netperf TCP_RR with 200 flows:
...
> Signed-off-by: Tom Herbert <therbert@google.com>
Applied, thanks Tom.
next prev parent reply other threads:[~2014-07-08 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:50 [PATCH v2] net: Performance fix for process_backlog Tom Herbert
2014-06-30 19:28 ` Eric Dumazet
2014-07-08 2:25 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-30 16:48 Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707.192519.1302110449886053251.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).