From: David Miller <davem@davemloft.net>
To: loicp@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
timo.teras@iki.fi, jiri@resnulli.us
Subject: Re: [PATCH] net: Fix NETDEV_CHANGE notifier usage causing spurious arp flush
Date: Mon, 07 Jul 2014 21:20:34 -0700 (PDT) [thread overview]
Message-ID: <20140707.212034.2224956636540078311.davem@davemloft.net> (raw)
In-Reply-To: <1404275983-7908-1-git-send-email-loicp@google.com>
From: Loic Prylli <loicp@google.com>
Date: Tue, 1 Jul 2014 21:39:43 -0700
> A bug was introduced in NETDEV_CHANGE notifier sequence causing the
> arp table to be sometimes spuriously cleared (including manual arp
> entries marked permanent), upon network link carrier changes.
>
> The changed argument for the notifier was applied only to a single
> caller of NETDEV_CHANGE, missing among others netdev_state_change().
> So upon net_carrier events induced by the network, which are
> triggering a call to netdev_state_change(), arp_netdev_event() would
> decide whether to clear or not arp cache based on random/junk stack
> values (a kind of read buffer overflow).
>
> Fixes: be9efd365328 ("net: pass changed flags along with NETDEV_CHANGE event")
> Fixes: 6c8b4e3ff81b ("arp: flush arp cache on IFF_NOARP change")
> Signed-off-by: Loic Prylli <loicp@google.com>
Applied, thanks.
We should probably make plain call_netdevice_notifiers() BUG if it is
invoked for NETDEV_CHANGE.
prev parent reply other threads:[~2014-07-08 4:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 4:39 [PATCH] net: Fix NETDEV_CHANGE notifier usage causing spurious arp flush Loic Prylli
2014-07-02 7:03 ` Dan Aloni
2014-07-07 20:34 ` Loic Prylli
2014-07-08 4:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707.212034.2224956636540078311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=loicp@google.com \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).