From: David Miller <davem@davemloft.net>
To: macro@linux-mips.org
Cc: netdev@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH v3] declance: Fix 64-bit compilation warnings
Date: Tue, 08 Jul 2014 14:05:02 -0700 (PDT) [thread overview]
Message-ID: <20140708.140502.2094195777978560656.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.11.1407030552290.15455@eddie.linux-mips.org>
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 3 Jul 2014 05:56:51 +0100 (BST)
> This fixes compiler warnings:
>
> drivers/net/ethernet/amd/declance.c: In function 'lance_init_ring':
> drivers/net/ethernet/amd/declance.c:478: warning: format '%8.8x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
> drivers/net/ethernet/amd/declance.c:487: warning: format '%8.8x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
> drivers/net/ethernet/amd/declance.c:503: warning: cast from pointer to integer of different size
> drivers/net/ethernet/amd/declance.c:520: warning: cast from pointer to integer of different size
>
> in 64-bit compilation. Where the value printed is an offset (whose range
> will always fit) the cast uses a 32-bit type, otherwise, where it is a
> host memory address, the pointer is output directly with %p. Also the
> remaining `0x' prefix is dropped for consistency across these messages.
>
> Tested with both 32-bit and 64-bit compilation, as well as at the run time
> (with the debug messages affected enabled).
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> Update from v2 switches to using the %p format specifier where
> appropriate and drops the `0x' prefix for consistency across these debug
> messages. Please apply.
Applied to net-next, thank you.
prev parent reply other threads:[~2014-07-08 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 4:56 [PATCH v3] declance: Fix 64-bit compilation warnings Maciej W. Rozycki
2014-07-08 21:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.140502.2094195777978560656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).