From: David Miller <davem@davemloft.net>
To: macro@linux-mips.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] defxx: Fix issues with debug printk calls
Date: Tue, 08 Jul 2014 15:32:11 -0700 (PDT) [thread overview]
Message-ID: <20140708.153211.1389512038724757200.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.11.1407051520310.15455@eddie.linux-mips.org>
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Sat, 5 Jul 2014 15:28:22 +0100 (BST)
> This fixes issues with debug printk calls across the driver, normally
> disabled; first compilation errors:
>
> drivers/net/fddi/defxx.c:676:1: error: pasting "(" and ""In dfx_bus_init...\n"" does not give a valid preprocessing token
> drivers/net/fddi/defxx.c:820:1: error: pasting "(" and ""In dfx_bus_uninit...\n"" does not give a valid preprocessing token
>
> and so on, and then warnings:
>
> drivers/net/fddi/defxx.c: In function 'dfx_driver_init':
> drivers/net/fddi/defxx.c:1132: warning: format '%0X' expects type 'unsigned int', but argument 4 has type 'dma_addr_t'
> drivers/net/fddi/defxx.c:1132: warning: format '%0X' expects type 'unsigned int', but argument 4 has type 'dma_addr_t'
>
> etc. Additionally casts are removed from virtual addresses and %p used.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Applied to net-next, thanks.
prev parent reply other threads:[~2014-07-08 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 14:28 [PATCH] defxx: Fix issues with debug printk calls Maciej W. Rozycki
2014-07-05 16:44 ` Joe Perches
2014-07-05 17:29 ` Maciej W. Rozycki
2014-07-08 22:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.153211.1389512038724757200.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).