From: David Miller <davem@davemloft.net>
To: jon.maloy@ericsson.com
Cc: netdev@vger.kernel.org, paul.gortmaker@windriver.com,
erik.hugne@ericsson.com, ying.xue@windriver.com,
maloy@donjonn.com, tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: fix bug in multicast/broadcast message reassembly
Date: Tue, 08 Jul 2014 15:55:42 -0700 (PDT) [thread overview]
Message-ID: <20140708.155542.2880546866748428.davem@davemloft.net> (raw)
In-Reply-To: <1404582253-21815-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Sat, 5 Jul 2014 13:44:13 -0400
> Since commit 37e22164a8a3c39bdad45aa463b1e69a1fdf4110 ("tipc: rename and
> move message reassembly function") reassembly of long broadcast messages
> has been broken. This is because we test for a non-NULL return value
> of the *buf parameter as criteria for succesful reassembly. However, this
> parameter is left defined even after reception of the first fragment,
> when reassebly is still incomplete. This leads to a kernel crash as soon
> as a the first fragment of a long broadcast message is received.
>
> We fix this with this commit, by implementing a stricter behavior of the
> function and its return values.
>
> This commit should be applied to both net and net-next.
>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thanks.
prev parent reply other threads:[~2014-07-08 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 17:44 [PATCH net 1/1] tipc: fix bug in multicast/broadcast message reassembly Jon Maloy
2014-07-07 3:22 ` Ying Xue
2014-07-08 22:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.155542.2880546866748428.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).