From: David Miller <davem@davemloft.net>
To: himangi774@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] iaf_packet: use BUG_ON
Date: Tue, 08 Jul 2014 16:22:04 -0700 (PDT) [thread overview]
Message-ID: <20140708.162204.1648218023530822781.davem@davemloft.net> (raw)
In-Reply-To: <20140708222023.GA11829@himangi-Dell>
From: Himangi Saraogi <himangi774@gmail.com>
Date: Wed, 9 Jul 2014 03:50:23 +0530
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Please repost this with a proper subject line, correcting "iaf_packet".
prev parent reply other threads:[~2014-07-08 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 22:20 [PATCH] iaf_packet: use BUG_ON Himangi Saraogi
2014-07-08 23:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.162204.1648218023530822781.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).