From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
yevgenyp@mellanox.com, ogerlitz@mellanox.com
Subject: Re: [PATCH net] net/mlx4_en: Ignore budget on TX napi polling
Date: Tue, 08 Jul 2014 20:01:16 -0700 (PDT) [thread overview]
Message-ID: <20140708.200116.1002049422940185215.davem@davemloft.net> (raw)
In-Reply-To: <1404808092-29411-1-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Tue, 8 Jul 2014 11:28:12 +0300
> It is recommended that TX work not count against the quota.
> The cost of TX packet liberation is a minute percentage of what it costs to
> process an RX frame. Furthermore, that SKB freeing makes memory available for
> other paths in the stack.
>
> Give the TX a larger budget and be more aggressive about cleaning up the Tx
> descriptors this budget could be changed using ethtool:
> $ ethtool -C eth1 tx-frames-irq <budget>
>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
Applied, thanks for following up on this.
prev parent reply other threads:[~2014-07-09 3:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 8:28 [PATCH net] net/mlx4_en: Ignore budget on TX napi polling Amir Vadai
2014-07-09 3:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.200116.1002049422940185215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).