From: David Miller <davem@davemloft.net>
To: fitzsim@fitzsim.org
Cc: netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com,
jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH resend] net: mvneta: Fix big endian issue in mvneta_txq_desc_csum()
Date: Tue, 08 Jul 2014 20:52:08 -0700 (PDT) [thread overview]
Message-ID: <20140708.205208.1742283754280003313.davem@davemloft.net> (raw)
In-Reply-To: <m3wqbnpgag.fsf@fitzsim.org>
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Date: Tue, 08 Jul 2014 19:44:07 -0400
> This commit fixes the command value generated for CSUM calculation
> when running in big endian mode. The Ethernet protocol ID for IP was
> being unconditionally byte-swapped in the layer 3 protocol check (with
> swab16), which caused the mvneta driver to not function correctly in
> big endian mode. This patch byte-swaps the ID conditionally with
> htons.
>
> Cc: <stable@vger.kernel.org> # v3.13+
> Signed-off-by: Thomas Fitzsimmons <fitzsim@fitzsim.org>
> ---
> The mvneta driver existed prior to v3.13, but it has only supported big
> endian from v3.13 onward. If it's accepted, this patch needs to be
> backported for stable only as far back as v3.13.
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-07-09 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 23:44 [PATCH resend] net: mvneta: Fix big endian issue in mvneta_txq_desc_csum() Thomas Fitzsimmons
2014-07-09 3:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708.205208.1742283754280003313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=fitzsim@fitzsim.org \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).