From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH resend] net: mvneta: Fix big endian issue in mvneta_txq_desc_csum() Date: Tue, 08 Jul 2014 20:52:08 -0700 (PDT) Message-ID: <20140708.205208.1742283754280003313.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, thomas.petazzoni@free-electrons.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, linux-arm-kernel@lists.infradead.org To: fitzsim@fitzsim.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:56258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbaGIDwJ (ORCPT ); Tue, 8 Jul 2014 23:52:09 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Thomas Fitzsimmons Date: Tue, 08 Jul 2014 19:44:07 -0400 > This commit fixes the command value generated for CSUM calculation > when running in big endian mode. The Ethernet protocol ID for IP was > being unconditionally byte-swapped in the layer 3 protocol check (with > swab16), which caused the mvneta driver to not function correctly in > big endian mode. This patch byte-swaps the ID conditionally with > htons. > > Cc: # v3.13+ > Signed-off-by: Thomas Fitzsimmons > --- > The mvneta driver existed prior to v3.13, but it has only supported big > endian from v3.13 onward. If it's accepted, this patch needs to be > backported for stable only as far back as v3.13. Applied and queued up for -stable, thanks.