[PATCH net-next] net: phy: export phy_suspend and phy_resume

[PATCH net-next] net: phy: export phy_suspend and phy_resume

[Florian Fainelli]

phy_suspend and phy_resume are two commonly used helper functions that
need to be exported for Ethernet drivers to be built as modules

Fixes: 40755a0fce17 ("net: systemport: add suspend and resume support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/phy/phy_device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 35d753d22f78..4f4568ef124e 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -696,6 +696,7 @@ int phy_suspend(struct phy_device *phydev)
 		return phydrv->suspend(phydev);
 	return 0;
 }
+EXPORT_SYMBOL(phy_suspend);
 
 int phy_resume(struct phy_device *phydev)
 {
@@ -705,6 +706,7 @@ int phy_resume(struct phy_device *phydev)
 		return phydrv->resume(phydev);
 	return 0;
 }
+EXPORT_SYMBOL(phy_resume);
 
 /* Generic PHY support and helper functions */
 
-- 
1.9.1

Re: [PATCH net-next] net: phy: export phy_suspend and phy_resume

[David Miller]

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue,  8 Jul 2014 10:38:36 -0700

> phy_suspend and phy_resume are two commonly used helper functions that
> need to be exported for Ethernet drivers to be built as modules
> 
> Fixes: 40755a0fce17 ("net: systemport: add suspend and resume support")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

First of all, the commit in question went into 'net' not 'net-next'.

Second of all, I reverted it.

So this patch is not appropriate unless/until that commit gets
re-added, and it's not targetted at the proper tree anyways.

Re: [PATCH net-next] net: phy: export phy_suspend and phy_resume

[Florian Fainelli]

2014-07-08 20:37 GMT-07:00 David Miller <davem@davemloft.net>:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue,  8 Jul 2014 10:38:36 -0700
>
>> phy_suspend and phy_resume are two commonly used helper functions that
>> need to be exported for Ethernet drivers to be built as modules
>>
>> Fixes: 40755a0fce17 ("net: systemport: add suspend and resume support")
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> First of all, the commit in question went into 'net' not 'net-next'.

I am confused now, because I sent the patches against net-next and
still see them in your net-next tree here:

https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=40755a0fce17c39557fd55b634024082671074ed

>
> Second of all, I reverted it.

I remember you replied to Vince about his patches which also depended
on phy_suspend/resume to be there and you did revert his changes.

>
> So this patch is not appropriate unless/until that commit gets
> re-added, and it's not targetted at the proper tree anyways.
-- 
Florian

Re: [PATCH net-next] net: phy: export phy_suspend and phy_resume

[David Miller]

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 8 Jul 2014 20:59:47 -0700

> 2014-07-08 20:37 GMT-07:00 David Miller <davem@davemloft.net>:
>> From: Florian Fainelli <f.fainelli@gmail.com>
>> Date: Tue,  8 Jul 2014 10:38:36 -0700
>>
>>> phy_suspend and phy_resume are two commonly used helper functions that
>>> need to be exported for Ethernet drivers to be built as modules
>>>
>>> Fixes: 40755a0fce17 ("net: systemport: add suspend and resume support")
>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> First of all, the commit in question went into 'net' not 'net-next'.
> 
> I am confused now, because I sent the patches against net-next and
> still see them in your net-next tree here:
> 
> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=40755a0fce17c39557fd55b634024082671074ed
> 
>>
>> Second of all, I reverted it.
> 
> I remember you replied to Vince about his patches which also depended
> on phy_suspend/resume to be there and you did revert his changes.

Indeed, I confused your and Vince's patches.  Sorry about that.

I'll apply your patch to net-next, thanks.