From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH net-next v4] xen-netback: Adding debugfs "io_ring_qX" files
Date: Tue, 8 Jul 2014 14:59:24 -0400 [thread overview]
Message-ID: <20140708185923.GA32404@laptop.dumpdata.com> (raw)
In-Reply-To: <1404845354-16237-1-git-send-email-zoltan.kiss@citrix.com>
> @@ -246,8 +415,12 @@ static void backend_create_xenvif(struct backend_info *be)
>
> static void backend_disconnect(struct backend_info *be)
> {
> - if (be->vif)
> + if (be->vif) {
> +#ifdef CONFIG_DEBUG_FS
> + xenvif_debugfs_delif(be->vif);
> +#endif /* CONFIG_DEBUG_FS */
> xenvif_disconnect(be->vif);
> + }
> }
>
> static void backend_connect(struct backend_info *be)
> @@ -560,6 +733,9 @@ static void connect(struct backend_info *be)
> be->vif->num_queues = queue_index;
> goto err;
> }
> +#ifdef CONFIG_DEBUG_FS
> + xenvif_debugfs_addif(queue);
> +#endif /* CONFIG_DEBUG_FS */
You really like those /* CONFIG_DEBUG_FS */ comments, eh :-)
> }
>
> /* Initialisation completed, tell core driver the number of
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-07-08 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 18:49 [PATCH net-next v4] xen-netback: Adding debugfs "io_ring_qX" files Zoltan Kiss
2014-07-08 18:59 ` Konrad Rzeszutek Wilk [this message]
2014-07-09 3:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708185923.GA32404@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).