From: David Miller <davem@davemloft.net>
To: fabf@skynet.be
Cc: linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1 net-next] ipconfig: move ic_dev_xid under IPCONFIG_BOOTP
Date: Wed, 09 Jul 2014 14:33:12 -0700 (PDT) [thread overview]
Message-ID: <20140709.143312.1847154920217915711.davem@davemloft.net> (raw)
In-Reply-To: <1404930921-14879-1-git-send-email-fabf@skynet.be>
From: Fabian Frederick <fabf@skynet.be>
Date: Wed, 9 Jul 2014 20:35:21 +0200
> ic_dev_xid is only used in __init ic_bootp_recv under IPCONFIG_BOOTP
> and __init ic_dynamic under IPCONFIG_DYNAMIC(which is itself defined
> with the same IPCONFIG_BOOTP)
>
> This patch fixes the following warning when IPCONFIG_BOOTP is not set:
>>> net/ipv4/ipconfig.c:146:15: warning: 'ic_dev_xid' defined but not used [-Wunused-variable]
> static __be32 ic_dev_xid; /* Device under configuration */
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Fengguang Wu <fengguang.wu@intel.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Applied, thank you.
prev parent reply other threads:[~2014-07-09 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 18:35 [PATCH 1/1 net-next] ipconfig: move ic_dev_xid under IPCONFIG_BOOTP Fabian Frederick
2014-07-09 21:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709.143312.1847154920217915711.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabf@skynet.be \
--cc=fengguang.wu@intel.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).