From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net v2] r8169: disable L23 Date: Wed, 09 Jul 2014 16:42:38 -0700 (PDT) Message-ID: <20140709.164238.899320392607428223.davem@davemloft.net> References: <1394712342-15778-6-Taiwan-albertk@realtek.com> <1394712342-15778-7-Taiwan-albertk@realtek.com> <20140709220954.GA30848@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hayeswang@realtek.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nic_swsd@realtek.com To: romieu@fr.zoreil.com Return-path: In-Reply-To: <20140709220954.GA30848@electric-eye.fr.zoreil.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Francois Romieu Date: Thu, 10 Jul 2014 00:09:54 +0200 > Hayes Wang : >> For RTL8411, RTL8111G, RTL8402, RTL8105, and RTL8106, disable the feature >> of entering the L2/L3 link state of the PCIe. When the nic starts the process >> of entering the L2/L3 link state and the PCI reset occurs before the work >> is finished, the work would be queued and continue after the next the PCI >> reset occurs. This causes the device stays in L2/L3 link state, and the system >> couldn't find the device. >> >> Signed-off-by: Hayes Wang > > Acked-by: Francois Romieu > > Thanks, the explanation of the race between software induced PCI reset > and transition to PCIe L2/L3 should be clear enough. PM scared me, yet > it got worse. > > Davem, would you mind to s/rtl_l23_enable/rtl_pcie_state_l2l3_enable/ or > do you want a new patch for it ? Applied with the function name adjusted, thanks.