[PATCH] dp83640: Always decode received status frames

[PATCH] dp83640: Always decode received status frames

[Stefan Sørensen]

Currently status frames are only handled when packet timestamping is
enabled, but status frames are also needed for pin event timestamping.

Fix by moving packet timestamping check to after status frame decode.

Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
 drivers/net/phy/dp83640.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 6a999e6..9408157 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1323,15 +1323,15 @@ static bool dp83640_rxtstamp(struct phy_device *phydev,
 {
 	struct dp83640_private *dp83640 = phydev->priv;
 
-	if (!dp83640->hwts_rx_en)
-		return false;
-
 	if (is_status_frame(skb, type)) {
 		decode_status_frame(dp83640, skb);
 		kfree_skb(skb);
 		return true;
 	}
 
+	if (!dp83640->hwts_rx_en)
+		return false;
+
 	SKB_PTP_TYPE(skb) = type;
 	skb_queue_tail(&dp83640->rx_queue, skb);
 	schedule_work(&dp83640->ts_work);
-- 
1.9.3

Re: [PATCH] dp83640: Always decode received status frames

[Richard Cochran]

On Wed, Jun 25, 2014 at 02:40:16PM +0200, Stefan Sørensen wrote:
> Currently status frames are only handled when packet timestamping is
> enabled, but status frames are also needed for pin event timestamping.
> 
> Fix by moving packet timestamping check to after status frame decode.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>

Re: [PATCH] dp83640: Always decode received status frames

[Sørensen, Stefan]

On Wed, 2014-06-25 at 14:40 +0200, Stefan Sørensen wrote:
> Currently status frames are only handled when packet timestamping is
> enabled, but status frames are also needed for pin event timestamping.
> 
> Fix by moving packet timestamping check to after status frame decode.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

Dave, I have noticed that this patch is marked as superseded in
patchworks (http://patchwork.ozlabs.org/patch/363989/), though I have
not posted any updated patch and only response is an Acked-By from
Richard.

Stefan

Re: [PATCH] dp83640: Always decode received status frames

[David Miller]

From: Sørensen, Stefan <Stefan.Sorensen@spectralink.com>
Date: Tue, 8 Jul 2014 06:39:52 +0000

> On Wed, 2014-06-25 at 14:40 +0200, Stefan Sørensen wrote:
>> Currently status frames are only handled when packet timestamping is
>> enabled, but status frames are also needed for pin event timestamping.
>> 
>> Fix by moving packet timestamping check to after status frame decode.
>> 
>> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
> 
> Dave, I have noticed that this patch is marked as superseded in
> patchworks (http://patchwork.ozlabs.org/patch/363989/), though I have
> not posted any updated patch and only response is an Acked-By from
> Richard.

Sorry about that, applied, thanks.