From: Veaceslav Falico <vfalico@redhat.com>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: Mahesh Bandewar <maheshb@google.com>,
Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Maciej Zenczykowski <maze@google.com>
Subject: Re: [PATCH] bonding: Do not try to send packets over dead link in TLB mode.
Date: Wed, 9 Jul 2014 14:04:37 +0200 [thread overview]
Message-ID: <20140709120437.GC1227@redhat.com> (raw)
In-Reply-To: <53BD18A7.6090109@redhat.com>
On Wed, Jul 09, 2014 at 12:25:43PM +0200, Nikolay Aleksandrov wrote:
>On 07/09/2014 12:24 PM, Veaceslav Falico wrote:
>> On Tue, Jul 08, 2014 at 06:09:58PM -0700, Mahesh Bandewar wrote:
...snip...
>>> + spin_lock(&bond_info->slave_arr_lock);
>>
>> I don't think you can re-enter bond_alb_handle_link_change(), as it's
>> protected either by rtnl or write-lock curr_active_slave.
>>
>Actually a very good catch :-)
>Maybe the allocation above should be done with GFP_ATOMIC.
For the record - it's indeed always under rtnl, so ASSERT_RTNL() (from your
other email) is a good idea.
next prev parent reply other threads:[~2014-07-09 12:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 1:09 [PATCH] bonding: Do not try to send packets over dead link in TLB mode Mahesh Bandewar
2014-07-09 7:10 ` Eric Dumazet
[not found] ` <CAF2d9jh1jDL7NMZapGn_Ohy8Y2JzHrWaKA5gFgR0tU=_KydtPg@mail.gmail.com>
2014-07-09 17:09 ` Eric Dumazet
2014-07-09 17:21 ` Mahesh Bandewar
2014-07-09 10:14 ` Nikolay Aleksandrov
2014-07-09 10:24 ` Veaceslav Falico
2014-07-09 10:25 ` Nikolay Aleksandrov
2014-07-09 12:04 ` Veaceslav Falico [this message]
2014-07-09 13:17 ` Eric Dumazet
2014-07-09 13:27 ` Veaceslav Falico
2014-07-09 17:15 ` Mahesh Bandewar
2014-07-09 17:24 ` Mahesh Bandewar
2014-07-09 21:07 ` Nikolay Aleksandrov
2014-07-10 8:25 ` Maciej Żenczykowski
2014-07-09 16:52 ` Mahesh Bandewar
2014-07-10 13:39 ` Jay Vosburgh
2014-07-10 14:40 ` Mahesh Bandewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709120437.GC1227@redhat.com \
--to=vfalico@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fubar@us.ibm.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).