From: Richard Cochran <richardcochran@gmail.com>
To: "Stefan Sørensen" <stefan.sorensen@spectralink.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] dp83640: Adjust ptp event timestamps
Date: Wed, 9 Jul 2014 19:41:49 +0200 [thread overview]
Message-ID: <20140709174149.GA3859@localhost.localdomain> (raw)
In-Reply-To: <1404901343-19445-1-git-send-email-stefan.sorensen@spectralink.com>
On Wed, Jul 09, 2014 at 12:22:23PM +0200, Stefan Sørensen wrote:
> From the dp86340 Software Development Guide:
> Event timestamp values should be adjusted by 3*reference clock period +
> 11 ns = 35 ns to compensate for input path and synchronization delays.
>
> So subtract 35ns from event timestamps.
I have avoided adding this kind of thing into drivers because I think
people will want to make the correction in the delayAsymmetry field of
their user space stack. After all, this is exactly what that value is
supposed to cover.
Some parts have fixed delays (or at least they claim to) and some have
variable delays that can depend on link speed or other factors. So my
gut feeling tells me to be consistent and leave all such corrections
out, because in that way the end user will not have to research
whether a particular driver is "pre-correcting" or not.
Thanks,
Richard
next prev parent reply other threads:[~2014-07-09 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 10:22 [PATCH net-next] dp83640: Adjust ptp event timestamps Stefan Sørensen
2014-07-09 17:41 ` Richard Cochran [this message]
2014-07-10 9:13 ` Sørensen, Stefan
2014-07-10 17:34 ` Richard Cochran
2014-07-10 17:35 ` Richard Cochran
2014-07-10 17:38 ` Richard Cochran
-- strict thread matches above, loose matches on Subject: below --
2014-07-11 6:18 Stefan Sørensen
2014-07-11 21:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709174149.GA3859@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).