From: David Miller <davem@davemloft.net>
To: sonic.adi@gmail.com
Cc: netdev@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
sonic.zhang@analog.com
Subject: Re: [PATCH] bfin_mac: convert bfin Ethernet driver to NAPI framework
Date: Thu, 10 Jul 2014 16:53:42 -0700 (PDT) [thread overview]
Message-ID: <20140710.165342.434372844542249917.davem@davemloft.net> (raw)
In-Reply-To: <1404985944-30463-1-git-send-email-sonic.adi@gmail.com>
From: Sonic Zhang <sonic.adi@gmail.com>
Date: Thu, 10 Jul 2014 17:52:24 +0800
> + if (i < budget && !test_bit(NAPI_STATE_NPSVC, &napi->state)) {
> + napi_complete(napi);
> + enable_irq(IRQ_MAC_RX);
> + }
Drivers are not supposed to test this bit directly.
If you have not exhausted the budget, and the chip has no more work to
do, you should unconditionally exit the NAPI poll.
next prev parent reply other threads:[~2014-07-10 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 9:52 [PATCH] bfin_mac: convert bfin Ethernet driver to NAPI framework Sonic Zhang
2014-07-10 23:53 ` David Miller [this message]
2014-07-11 4:57 ` Sonic Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710.165342.434372844542249917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).