From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "'Olivier Sobrie'" <olivier@sobrie.be>,
David Miller <davem@davemloft.net>,
"j.dumon@option.com" <j.dumon@option.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data
Date: Thu, 10 Jul 2014 22:20:30 +0100 [thread overview]
Message-ID: <20140710222030.0a194b1b@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D17270187@AcuExch.aculab.com>
> You really want to apply flow control back over the 'serial' link.
> That may just cause data discards earlier on the local system.
> But it is possible that not resubmitting the receive urb will cause the
> modem to flow control back to the sender.
> In which case there is some chance that data won't be lost.
If you are doing PPP and you can't keep up the sooner you chuck data the
better. Flow control actually works against performance and good network
behaviour. It's counter intuitive but TCP/IP works best if any
performance bottlenecks are immediately visible and not covered over.
Alan
next prev parent reply other threads:[~2014-07-10 21:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 9:06 [PATCH 1/2] hso: remove unused workqueue Olivier Sobrie
2014-07-07 9:06 ` [PATCH 2/2] hso: fix deadlock when receiving bursts of data Olivier Sobrie
2014-07-07 9:13 ` David Laight
2014-07-07 10:42 ` Olivier Sobrie
2014-07-07 12:55 ` David Laight
2014-07-07 13:38 ` Olivier Sobrie
2014-07-07 16:41 ` Dan Williams
2014-07-07 18:50 ` Olivier Sobrie
2014-07-08 23:16 ` David Miller
2014-07-10 14:28 ` Olivier Sobrie
2014-07-10 14:37 ` David Laight
2014-07-10 15:50 ` One Thousand Gnomes
2014-07-10 15:55 ` David Laight
2014-07-10 21:20 ` One Thousand Gnomes [this message]
2014-07-11 9:18 ` Olivier Sobrie
2014-07-11 9:28 ` David Laight
2014-07-11 12:05 ` Olivier Sobrie
2014-07-11 13:05 ` [PATCH v2 " Olivier Sobrie
2014-07-11 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710222030.0a194b1b@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@sobrie.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).