From: David Miller <davem@davemloft.net>
To: teg@jklm.no
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dh.herrmann@gmail.com, kay@vrfy.org
Subject: Re: [PATCH v8 1/4] net: add name_assign_type netdev attribute
Date: Fri, 11 Jul 2014 12:23:01 -0700 (PDT) [thread overview]
Message-ID: <20140711.122301.94365507620163228.davem@davemloft.net> (raw)
In-Reply-To: <1405026066-2547-2-git-send-email-teg@jklm.no>
From: Tom Gundersen <teg@jklm.no>
Date: Thu, 10 Jul 2014 23:01:03 +0200
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 30eedf6..392c784 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6438,11 +6438,12 @@ void netdev_freemem(struct net_device *dev)
>
> /**
> * alloc_netdev_mqs - allocate network device
> - * @sizeof_priv: size of private data to allocate space for
> - * @name: device name format string
> - * @setup: callback to initialize device
> - * @txqs: the number of TX subqueues to allocate
> - * @rxqs: the number of RX subqueues to allocate
> + * @sizeof_priv: size of private data to allocate space for
> + * @name: device name format string
> + * @name_assign_type: origin of device name
> + * @setup: callback to initialize device
> + * @txqs: the number of TX subqueues to allocate
> + * @rxqs: the number of RX subqueues to allocate
> *
> * Allocates a struct net_device with private data area for driver use
> * and performs basic initialization. Also allocates subqueue structs
This belongs in patch #3, where you actually change the arguments to
this interface, not here.
next prev parent reply other threads:[~2014-07-11 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 21:01 [PATCH v8 00/4] Provide netdev naming-policy via sysfs Tom Gundersen
2014-07-10 21:01 ` [PATCH v8 1/4] net: add name_assign_type netdev attribute Tom Gundersen
2014-07-11 19:23 ` David Miller [this message]
2014-07-10 21:01 ` [PATCH v8 2/4] net: set name assign type for renamed devices Tom Gundersen
2014-07-10 21:01 ` [PATCH v8 3/4] net: set name_assign_type in alloc_netdev() Tom Gundersen
2014-07-10 21:01 ` [PATCH v8 4/4] net: rtnetlink - make create_link take name_assign_type Tom Gundersen
2014-07-11 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711.122301.94365507620163228.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).