From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 02/11] net: bcmgenet: add umac_enable_set helper
Date: Fri, 11 Jul 2014 13:39:56 -0700 (PDT) [thread overview]
Message-ID: <20140711.133956.1369622097201965432.davem@davemloft.net> (raw)
In-Reply-To: <1405032384-24006-3-git-send-email-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 10 Jul 2014 15:46:15 -0700
> +static void umac_enable_set(struct bcmgenet_priv *priv, u32 mask,
> + unsigned int enable)
'enable' is strictly used as a boolean, so please use 'bool' and
true/false, thanks.
next prev parent reply other threads:[~2014-07-11 20:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 22:46 [PATCH net-next 00/11] net: bcmgenet: PM and Wake-on-LAN Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 01/11] net: bcmgenet: remove wol_enabled conditional code Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 02/11] net: bcmgenet: add umac_enable_set helper Florian Fainelli
2014-07-11 20:39 ` David Miller [this message]
2014-07-10 22:46 ` [PATCH net-next 03/11] net: bcmgenet: modularize bcmgenet_{open,close} Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 04/11] net: bcmgenet: add suspend/resume callbacks Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 05/11] net: bcmgenet: request Wake-on-LAN interrupt Florian Fainelli
2014-07-11 20:41 ` David Miller
2014-07-10 22:46 ` [PATCH net-next 06/11] net: bcmgenet: add Wake-on-LAN support code Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 07/11] net: bcmgenet: handle GENET_POWER_WOL_MAGIC Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 08/11] net: bcmgenet: handle UMAC_IRQ_MPD_R interrupt bit Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 09/11] net: bcmgenet: fix bcmgenet_wol_resume Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 10/11] net: bcmgenet: suspend and resume from Wake-on-LAN Florian Fainelli
2014-07-10 22:46 ` [PATCH net-next 11/11] net: bcmgenet: hook ethtool set/get_wol operations Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711.133956.1369622097201965432.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).