From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 02/11] net: bcmgenet: add umac_enable_set helper Date: Fri, 11 Jul 2014 13:39:56 -0700 (PDT) Message-ID: <20140711.133956.1369622097201965432.davem@davemloft.net> References: <1405032384-24006-1-git-send-email-f.fainelli@gmail.com> <1405032384-24006-3-git-send-email-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:57331 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbaGKUj5 (ORCPT ); Fri, 11 Jul 2014 16:39:57 -0400 In-Reply-To: <1405032384-24006-3-git-send-email-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Fainelli Date: Thu, 10 Jul 2014 15:46:15 -0700 > +static void umac_enable_set(struct bcmgenet_priv *priv, u32 mask, > + unsigned int enable) 'enable' is strictly used as a boolean, so please use 'bool' and true/false, thanks.