* [net] GRE: enable offloads for GRE
@ 2014-07-11 0:29 Jeff Kirsher
2014-07-11 20:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2014-07-11 0:29 UTC (permalink / raw)
To: davem
Cc: Amritha Nambiar, netdev, nhorman, sassmann, Joseph Gasparakis,
Jeff Kirsher
From: Amritha Nambiar <amritha.nambiar@intel.com>
To get offloads to work with Generic Routing Encapsulation (GRE), the
outer transport header has to be reset after skb_push is done. This
patch has the support for this fix and hence GRE offloading.
Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
Signed-off-by: Joseph Gasparakis <joseph.gasparakis@intel.com>
Tested-By: Jim Young <jamesx.m.young@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
net/ipv4/gre_demux.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/gre_demux.c b/net/ipv4/gre_demux.c
index 4e9619b..0485bf7 100644
--- a/net/ipv4/gre_demux.c
+++ b/net/ipv4/gre_demux.c
@@ -68,6 +68,7 @@ void gre_build_header(struct sk_buff *skb, const struct tnl_ptk_info *tpi,
skb_push(skb, hdr_len);
+ skb_reset_transport_header(skb);
greh = (struct gre_base_hdr *)skb->data;
greh->flags = tnl_flags_to_gre_flags(tpi->flags);
greh->protocol = tpi->proto;
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net] GRE: enable offloads for GRE
2014-07-11 0:29 [net] GRE: enable offloads for GRE Jeff Kirsher
@ 2014-07-11 20:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-11 20:54 UTC (permalink / raw)
To: jeffrey.t.kirsher
Cc: amritha.nambiar, netdev, nhorman, sassmann, joseph.gasparakis
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 10 Jul 2014 17:29:21 -0700
> From: Amritha Nambiar <amritha.nambiar@intel.com>
>
> To get offloads to work with Generic Routing Encapsulation (GRE), the
> outer transport header has to be reset after skb_push is done. This
> patch has the support for this fix and hence GRE offloading.
>
> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
> Signed-off-by: Joseph Gasparakis <joseph.gasparakis@intel.com>
> Tested-By: Jim Young <jamesx.m.young@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
I think, generally speaking, this is more about making sure the
SKB is in a proper state. If that happens to make offloads over
GRE work properly, that's certainly a nice side effect :)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-11 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 0:29 [net] GRE: enable offloads for GRE Jeff Kirsher
2014-07-11 20:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).