From: Olivier Sobrie <olivier@sobrie.be>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: David Laight <David.Laight@ACULAB.COM>,
David Miller <davem@davemloft.net>,
"j.dumon@option.com" <j.dumon@option.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data
Date: Fri, 11 Jul 2014 11:18:03 +0200 [thread overview]
Message-ID: <20140711091803.GA19663@hposo> (raw)
In-Reply-To: <20140710165003.0309924e@alan.etchedpixels.co.uk>
Hi Alan and Davids,
On Thu, Jul 10, 2014 at 04:50:03PM +0100, One Thousand Gnomes wrote:
> On Thu, 10 Jul 2014 14:37:37 +0000
> David Laight <David.Laight@ACULAB.COM> wrote:
>
> > From: Olivier Sobrie
> > ...
> > > The function put_rxbuf_data() is called from the urb completion handler.
> > > It puts the data of the urb transfer in the tty buffer with
> > > tty_insert_flip_string_flags() and schedules a work queue in order to
> > > push the data to the ldisc.
> > > Problem is that we are in a urb completion handler so we can't wait
> > > until there is room in the tty buffer.
>
> The tty provides the input queue, if the queue is full then just chuck
> the data in the bitbucket. hso is trying to be far too clever.
>
> If hso is fast enough that the buffering isn't sufficient on the tty side
> then we need to fix the tty buffer size.
Ok I'll adapt the patch to drop the data that can't be put in the tty
buffer. I test this and resend a new patch.
Thanks for your help!
--
Olivier
next prev parent reply other threads:[~2014-07-11 9:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 9:06 [PATCH 1/2] hso: remove unused workqueue Olivier Sobrie
2014-07-07 9:06 ` [PATCH 2/2] hso: fix deadlock when receiving bursts of data Olivier Sobrie
2014-07-07 9:13 ` David Laight
2014-07-07 10:42 ` Olivier Sobrie
2014-07-07 12:55 ` David Laight
2014-07-07 13:38 ` Olivier Sobrie
2014-07-07 16:41 ` Dan Williams
2014-07-07 18:50 ` Olivier Sobrie
2014-07-08 23:16 ` David Miller
2014-07-10 14:28 ` Olivier Sobrie
2014-07-10 14:37 ` David Laight
2014-07-10 15:50 ` One Thousand Gnomes
2014-07-10 15:55 ` David Laight
2014-07-10 21:20 ` One Thousand Gnomes
2014-07-11 9:18 ` Olivier Sobrie [this message]
2014-07-11 9:28 ` David Laight
2014-07-11 12:05 ` Olivier Sobrie
2014-07-11 13:05 ` [PATCH v2 " Olivier Sobrie
2014-07-11 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711091803.GA19663@hposo \
--to=olivier@sobrie.be \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).