From: Thomas Graf <tgraf@suug.ch>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, therbert@google.com,
nicolas.dichtel@6wind.com, pshelar@nicira.com,
xiyou.wangcong@gmail.com, ogerlitz@mellanox.com,
dborkman@redhat.com,
"Pritesh Kothari (pritkoth)" <pritkoth@cisco.com>,
Madhu Challa <challa@noironetworks.com>
Subject: Re: [PATCH 1/2 net-next] vxlan: Be liberal on receive and only require the I bit to be set
Date: Fri, 11 Jul 2014 22:28:11 +0100 [thread overview]
Message-ID: <20140711212811.GG13525@casper.infradead.org> (raw)
In-Reply-To: <20140711124126.262c2876@samsung-9>
On 07/11/14 at 12:41pm, Stephen Hemminger wrote:
> On Fri, 11 Jul 2014 18:59:49 +0200
> Thomas Graf <tgraf@suug.ch> wrote:
>
> > @@ -1617,7 +1646,9 @@ static int vxlan6_xmit_skb(struct vxlan_sock *vs,
> > }
> >
> > vxh = (struct vxlanhdr *) __skb_push(skb, sizeof(*vxh));
> > - vxh->vx_flags = htonl(VXLAN_FLAGS);
> > + vxlan_flags(vxh) = VXLAN_FLAG_VNI;
> > + vxh->vx_reserved1 = 0;
> > + vxh->vx_reserved2 = 0;
> > vxh->vx_vni = vni;
> >
>
> Okay, but initializing bitfields generates crappy code.
> Can we just alias and do one assignment.
Sure, I'll resend.
next prev parent reply other threads:[~2014-07-11 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 16:59 [PATCH 0/2 net-next] vxlan: Liberal parsing & basic VXLAN-gpe Thomas Graf
2014-07-11 16:59 ` [PATCH 1/2 net-next] vxlan: Be liberal on receive and only require the I bit to be set Thomas Graf
2014-07-11 19:41 ` Stephen Hemminger
2014-07-11 21:28 ` Thomas Graf [this message]
2014-07-14 8:46 ` David Laight
2014-07-13 22:08 ` Tom Herbert
2014-07-14 8:18 ` Thomas Graf
2014-07-15 7:18 ` Nicolas Dichtel
2014-07-11 16:59 ` [PATCH 2/2 net-next] vxlan: Minimal support for Generic Protocol Extension (VXLAN-gpe) Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711212811.GG13525@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=challa@noironetworks.com \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pritkoth@cisco.com \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).