From: David Miller <davem@davemloft.net>
To: minipli@googlemail.com
Cc: netdev@vger.kernel.org, spender@grsecurity.net
Subject: Re: [PATCH] neigh: sysctl - simplify address calculation of gc_* variables
Date: Mon, 14 Jul 2014 14:33:18 -0700 (PDT) [thread overview]
Message-ID: <20140714.143318.1099738757410344842.davem@davemloft.net> (raw)
In-Reply-To: <1405197404-19127-1-git-send-email-minipli@googlemail.com>
From: Mathias Krause <minipli@googlemail.com>
Date: Sat, 12 Jul 2014 22:36:44 +0200
> The code in neigh_sysctl_register() relies on a specific layout of
> struct neigh_table, namely that the 'gc_*' variables are directly
> following the 'parms' member in a specific order. The code, though,
> expresses this in the most ugly way.
>
> Get rid of the ugly casts and use the 'tbl' pointer to get a handle to
> the table. This way we can refer to the 'gc_*' variables directly.
>
> Similarly seen in the grsecurity patch, written by Brad Spengler.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> Cc: Brad Spengler <spender@grsecurity.net>
Looks good, applied, thanks.
prev parent reply other threads:[~2014-07-14 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 20:36 [PATCH] neigh: sysctl - simplify address calculation of gc_* variables Mathias Krause
2014-07-14 21:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714.143318.1099738757410344842.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).