* [PATCH net] bonding: fix ad_select module param check
@ 2014-07-13 7:47 Nikolay Aleksandrov
2014-07-14 21:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nikolay Aleksandrov @ 2014-07-13 7:47 UTC (permalink / raw)
To: netdev
Cc: Nikolay Aleksandrov, Jay Vosburgh, Veaceslav Falico,
Andy Gospodarek, David S. Miller
Obvious copy/paste error when I converted the ad_select to the new
option API. "lacp_rate" there should be "ad_select" so we can get the
proper value.
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: David S. Miller <davem@davemloft.net>
Fixes: 9e5f5eebe765 ("bonding: convert ad_select to use the new option
API")
Reported-by: Karim Scheik <karim.scheik@prisma-solutions.at>
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 3a451b6cd3d5..701f86cd5993 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4068,7 +4068,7 @@ static int bond_check_params(struct bond_params *params)
}
if (ad_select) {
- bond_opt_initstr(&newval, lacp_rate);
+ bond_opt_initstr(&newval, ad_select);
valptr = bond_opt_parse(bond_opt_get(BOND_OPT_AD_SELECT),
&newval);
if (!valptr) {
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bonding: fix ad_select module param check
2014-07-13 7:47 [PATCH net] bonding: fix ad_select module param check Nikolay Aleksandrov
@ 2014-07-14 21:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-14 21:37 UTC (permalink / raw)
To: nikolay; +Cc: netdev, j.vosburgh, vfalico, andy
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Sun, 13 Jul 2014 09:47:47 +0200
> Obvious copy/paste error when I converted the ad_select to the new
> option API. "lacp_rate" there should be "ad_select" so we can get the
> proper value.
>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: David S. Miller <davem@davemloft.net>
>
> Fixes: 9e5f5eebe765 ("bonding: convert ad_select to use the new option
> API")
> Reported-by: Karim Scheik <karim.scheik@prisma-solutions.at>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-14 21:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-13 7:47 [PATCH net] bonding: fix ad_select module param check Nikolay Aleksandrov
2014-07-14 21:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).