From: David Miller <davem@davemloft.net>
To: nikolay@redhat.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net-next] bonding: fix bond_option_mode_set warning
Date: Tue, 15 Jul 2014 22:56:13 -0700 (PDT) [thread overview]
Message-ID: <20140715.225613.1285857218662290489.davem@davemloft.net> (raw)
In-Reply-To: <1405433337-8806-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Tue, 15 Jul 2014 16:08:57 +0200
> During the conversion to "static" functions this one got left out, only its
> prototype was converted, thus resulting in:
> drivers/net/bonding//bond_options.c:674:5: warning: symbol
> 'bond_option_mode_set' was not declared. Should it be static?
>
> Fix it by making it static and also break the line in two as it was too
> long.
>
> CC: Stephen Hemminger <stephen@networkplumber.org>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: David S. Miller <davem@davemloft.net>
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Applied, thanks Nikolay.
prev parent reply other threads:[~2014-07-16 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 14:08 [PATCH net-next] bonding: fix bond_option_mode_set warning Nikolay Aleksandrov
2014-07-15 14:13 ` Nikolay Aleksandrov
2014-07-16 5:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715.225613.1285857218662290489.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).