From: Veaceslav Falico <vfalico@gmail.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH net-next] bonding: permit enslaving interfaces without set_mac support
Date: Tue, 15 Jul 2014 13:59:19 +0200 [thread overview]
Message-ID: <20140715115919.GA5225@mikrodark.usersys.redhat.com> (raw)
In-Reply-To: <53C5145E.5040908@gmail.com>
On Tue, Jul 15, 2014 at 05:15:34PM +0530, Varka Bhadram wrote:
>On 07/15/2014 04:56 PM, Veaceslav Falico wrote:
...snip...
>>- pr_warn("%s: Warning: The first slave device specified does not support setting the MAC address\n",
>>- bond_dev->name);
>>- if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP) {
>>+ pr_warn("%s: Warning: The slave device specified does not support setting the MAC address\n",
>>+ bond_dev->name);
>
>netdev_warn() instead of pr_warn()... We are having net_device object?
It's done in consistency with the whole function - there are pr_*
everywhere there, and netdev_x here and there would only mess things up.
I'll send a follow-up patch that transforms all pr_* into netdev_*.
Thank you!
next prev parent reply other threads:[~2014-07-15 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 11:26 [PATCH net-next] bonding: permit enslaving interfaces without set_mac support Veaceslav Falico
2014-07-15 11:45 ` Varka Bhadram
2014-07-15 11:59 ` Veaceslav Falico [this message]
2014-07-16 5:55 ` David Miller
2014-07-17 19:21 ` Jay Vosburgh
2014-07-17 19:31 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715115919.GA5225@mikrodark.usersys.redhat.com \
--to=vfalico@gmail.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).