From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@primarydata.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] net: clean up some sparse endianness warnings in ipv6.h
Date: Tue, 15 Jul 2014 10:01:07 -0700 [thread overview]
Message-ID: <20140715170107.GA1722@infradead.org> (raw)
In-Reply-To: <1405340746-10678-1-git-send-email-jlayton@primarydata.com>
> #if defined(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) && BITS_PER_LONG == 64
> - const unsigned long *ul = (const unsigned long *)a;
> + const __be64 *be = (const __be64 *)a;
>
> - return (ul[0] | (ul[1] ^ cpu_to_be64(1))) == 0UL;
> + return (be[0] | (be[1] ^ cpu_to_be64(1))) == cpu_to_be64(0UL);
Do you need the swap for 0UL? I know sparse treats 0 as special, so why
wouldn't it treat 0UL special? Or just remove the 0UL postfix, no need
for it in a simple comparism.
Otherwise looks fine to me.
next prev parent reply other threads:[~2014-07-15 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 12:25 [PATCH] net: clean up some sparse endianness warnings in ipv6.h Jeff Layton
2014-07-15 17:01 ` Christoph Hellwig [this message]
2014-07-15 17:17 ` Jeff Layton
[not found] ` <1405340746-10678-1-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-07-15 18:51 ` Jeff Layton
2014-07-15 23:05 ` David Miller
2014-07-16 10:55 ` [PATCH v2] " Jeff Layton
[not found] ` <1405508146-13004-1-git-send-email-jlayton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2014-07-17 6:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715170107.GA1722@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=jlayton@primarydata.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox