From: David Miller <davem@davemloft.net>
To: anish@chelsio.com
Cc: netdev@vger.kernel.org, leedom@chelsio.com, dan.carpenter@oracle.com
Subject: Re: [PATCH net-next] Update setapp/getapp prototypes in dcbnl_rtnl_ops to return int instead of u8
Date: Wed, 16 Jul 2014 22:23:03 -0700 (PDT) [thread overview]
Message-ID: <20140716.222303.1286422592325268399.davem@davemloft.net> (raw)
In-Reply-To: <1405571974-23143-1-git-send-email-anish@chelsio.com>
From: Anish Bhatt <anish@chelsio.com>
Date: Wed, 16 Jul 2014 21:39:34 -0700
> @@ -472,6 +472,8 @@ static int dcbnl_getapp(struct net_device *netdev, struct nlmsghdr *nlh,
>
> if (netdev->dcbnl_ops->getapp) {
> up = netdev->dcbnl_ops->getapp(netdev, idtype, id);
> + if (up < 0)
> + return up;
> } else {
> struct dcb_app app = {
> .selector = idtype,
'up' is u8 so can never be less than zero.
prev parent reply other threads:[~2014-07-17 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 4:39 [PATCH net-next] Update setapp/getapp prototypes in dcbnl_rtnl_ops to return int instead of u8 Anish Bhatt
2014-07-17 5:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140716.222303.1286422592325268399.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=dan.carpenter@oracle.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).