netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Veaceslav Falico <vfalico@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, andy@greyhouse.net
Subject: Re: [PATCH net-next 0/2] bonding: add its own Kconfig
Date: Wed, 16 Jul 2014 09:20:32 +0200	[thread overview]
Message-ID: <20140716072032.GA12030@mikrodark.usersys.redhat.com> (raw)
In-Reply-To: <20140715.181056.2116924949727575928.davem@davemloft.net>

On Tue, Jul 15, 2014 at 06:10:56PM -0700, David Miller wrote:
>From: Veaceslav Falico <vfalico@gmail.com>
>Date: Tue, 15 Jul 2014 12:15:39 +0200
>
>> Currently to change some built-in defaults it's necessary to change the
>> code, and to maintain these patches on each update.
>>
>> Create a bonding's Kconfig to make it possible to configure them at build
>> time.
>
>There is really no reason these values can't be set at run time, and that
>is my only, but firm, objection to this patch series.

Yeah, MIIMON default value doesn't really need to exist, vlan depth can be
configured dynamically ...

>
>For the per-slave things, make new netlink attributes that can be provided
>when the slave is added, using the existing default if not specified.
>
>This means the fixed sized arrays involved here need to become
>dynamically allocated.

... and arp ip targets can be also made into lists.

I'll try to change it and come up with split patchsets.

Thank you!

      reply	other threads:[~2014-07-16  7:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 10:15 [PATCH net-next 0/2] bonding: add its own Kconfig Veaceslav Falico
2014-07-15 10:15 ` [PATCH net-next 1/2] bonding: create " Veaceslav Falico
2014-07-15 10:15 ` [PATCH net-next 2/2] bonding: make hard-coded defines configurable at build Veaceslav Falico
2014-07-15 15:48   ` Alexei Starovoitov
2014-07-15 16:18     ` Veaceslav Falico
2014-07-15 16:45       ` Alexei Starovoitov
2014-07-15 17:11         ` Veaceslav Falico
2014-07-15 17:33           ` Alexei Starovoitov
2014-07-15 17:53             ` Veaceslav Falico
2014-07-15 18:55               ` Alexei Starovoitov
2014-07-15 19:18                 ` Veaceslav Falico
2014-07-16  1:01                   ` David Miller
2014-07-15 17:11   ` Sergei Shtylyov
2014-07-16  1:10 ` [PATCH net-next 0/2] bonding: add its own Kconfig David Miller
2014-07-16  7:20   ` Veaceslav Falico [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140716072032.GA12030@mikrodark.usersys.redhat.com \
    --to=vfalico@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=j.vosburgh@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).